Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20563 change fatal error message #10340

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Conversation

Stoob
Copy link
Contributor

@Stoob Stoob commented May 12, 2017

CRM-10293 and CRM-20563
@kngs
Copy link
Contributor

kngs commented May 12, 2017

I thought this might be a PR I could handle but thought maybe modifying the wording from "when this occured" to "what action you were performing when this occured".

@Stoob
Copy link
Contributor Author

Stoob commented May 13, 2017

I'm fine with that change. Please go ahead. As an aside, I'm not sure if we should be commenting in GitHub or JIRA.

Copy link
Contributor

@kngs kngs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest following wording change (approved by Stoob):
"Sorry, due to an error, CiviCRM is unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred."

@Stoob
Copy link
Contributor Author

Stoob commented May 17, 2017

@kngs I just got an important comment. "CiviCRM" is not appropriate for people who package the software under another name: PowerBase, BlueBird, etc.

Please replace "CiviCRM is" with "we are"

@Stoob
Copy link
Contributor Author

Stoob commented May 19, 2017

I have made the final text change incorporating your suggestions @kngs and others. ready for merge

@kngs
Copy link
Contributor

kngs commented May 24, 2017

Hi Stoob,
Don't know if you saw my message on MatterMost:

Hi Stoob, I'm sorry you had to make the change. I am still learning the PR system and was going to reach out to Ali, who walked me through my first PR, to make the changes. I also was trying to do a pre and post test; amazing how challenging it is to get that message when you want it!! I thought this would be an easy one but I still have a lot to learn. Is there anything else I need to do? Again my apologies for taking so long (still trying to catch up with work and life after the conference ). Karen

Do I still need to test or submit!?!?
Sorry again for being such a newbie!
Karen

@eileenmcnaughton
Copy link
Contributor

Looks like @Stoob approved this to merge and as a wording change that is good enough for me!

@eileenmcnaughton eileenmcnaughton merged commit 52186d7 into civicrm:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants